Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is there a CSVFileFormatException in RepoVisitor? #74

Open
mauricioaniche opened this issue Sep 28, 2017 · 2 comments
Open

Why is there a CSVFileFormatException in RepoVisitor? #74

mauricioaniche opened this issue Sep 28, 2017 · 2 comments

Comments

@mauricioaniche
Copy link
Owner

No description provided.

@mauricioaniche mauricioaniche mentioned this issue Sep 28, 2017
@davisjam
Copy link
Contributor

davisjam commented Sep 29, 2017

As I suggested in #72, I think we should really define what should happen if a CommitVisitor throws an exception. For example it might throw an exception due to the repository being in a bad state (e.g. git checkout failed). Should we abort or try to keep going?

I'm asking because I think we should document our position, whatever it is.

@mauricioaniche
Copy link
Owner Author

Maybe this can be configured by the user. She can choose to either halt the study or keep going!

To keep compatibility, we make default to keep going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants