Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidentals and key signatures don't work correctly #1

Open
mauritslamers opened this issue Mar 19, 2015 · 0 comments
Open

Accidentals and key signatures don't work correctly #1

mauritslamers opened this issue Mar 19, 2015 · 0 comments

Comments

@mauritslamers
Copy link
Owner

The current implementation of key signatures and accidentals ignores the octave of which an alteration took place. This is fine when dealing with a key signature, but is incorrect for accidentals.
When a note or chord occurs in a bar, the octave of the alteration determines whether an accidental is placed or not. This is currently not implemented correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant