Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敟 Better template import management #161

Closed
JohnPixle opened this issue Sep 12, 2019 · 3 comments
Closed

馃敟 Better template import management #161

JohnPixle opened this issue Sep 12, 2019 · 3 comments
Assignees
@mauryaratan @JohnPixle
Labels
Type: Feature New feature
Milestone
馃帥 SK 1.3.8

Comments

@JohnPixle
Copy link
Collaborator

I believe this must be one of our priorities for now, It is the first interaction with the user and an SK-powered template so we need to adapt this to a proper context.

馃憠馃徎 comments on figma: https://www.figma.com/file/WewTsQAjGvzRQahddcH0KK6m/Product-UI?node-id=529%3A118

Screenshot 2019-09-12 at 22 13 09
@JohnPixle JohnPixle added the Type: Feature New feature label Sep 12, 2019
@JohnPixle JohnPixle changed the title 馃敟 Reduce UX friction when importing templates 馃敟 Better template import managemment Sep 12, 2019
@JohnPixle JohnPixle changed the title 馃敟 Better template import managemment 馃敟 鈿狅笍 Better template import management Sep 12, 2019
@JohnPixle JohnPixle added this to the 1.3.7 milestone Sep 12, 2019
@JohnPixle JohnPixle changed the title 馃敟 鈿狅笍 Better template import management 馃敟 Better template import management Sep 12, 2019
@JohnPixle
Copy link
Collaborator Author

This design is subject to change into this:
Screenshot 2019-09-16 at 13 21 23

@mauryaratan
Copy link
Member

@JohnPixle a few questions?

  • Should this modal be followed before importing a template or after?
  • The bottom text saying default import method, what does it refer to?
  • The SK dropdown seen in the screenshot, does it lists our library SKs are all SKs on a users' site.
  • Lastly, we can probably drop this design and match existing or redo other popup modal as well.

Thanks.

@JohnPixle
Copy link
Collaborator Author

@mauryaratan

  1. Ideally, we do not want to display the layout without a stylekit applied on it, so i think it would be better to do it before.

  2. It refers to a potential idea about having an option to set a default behavior in the settings. We can postpone this functionality as it is not needed in the MVP

Screenshot 2019-09-18 at 16 32 23

  1. Both somehow if possible. If a template from our gallery is imported that has a style kit attached, , this Style Kit must be imported and applied on the template, if the user does not have it in his SK list.

  2. I think we must decide a global style for the popups, i will revise this one a bit.

mauryaratan added a commit that referenced this issue Oct 15, 2019
@mauryaratan
#161 Move SK data from component to App
cdbe7f7
mauryaratan added a commit that referenced this issue Oct 15, 2019
@mauryaratan
#161 Add ImportTemplate component for multistep import method
1435bab
mauryaratan added a commit that referenced this issue Oct 17, 2019
@mauryaratan
#161 Implement new import flow including SK
b332e4d
mauryaratan added a commit that referenced this issue Oct 20, 2019
@mauryaratan
#161 Fix Section being converted into Inner Sections
b1332ed
@mauryaratan mauryaratan mentioned this issue Oct 20, 2019
Closed
mauryaratan added a commit that referenced this issue Oct 21, 2019
@mauryaratan
#161 Bring template flow to Elementor screen
305384d
@mauryaratan mauryaratan mentioned this issue Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauryaratan mauryaratan

@JohnPixle JohnPixle

Labels
Type: Feature New feature
Projects
None yet
Milestone
馃帥 SK 1.3.8
Development

No branches or pull requests
2 participants
@mauryaratan @JohnPixle