Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Style Kit export isn't throwing an error as expected #97

Closed
lushkant opened this issue May 13, 2019 · 1 comment
Closed

Empty Style Kit export isn't throwing an error as expected #97

lushkant opened this issue May 13, 2019 · 1 comment
Assignees
Labels
Type: Bug Something isn't working Type: Feature New feature
Projects
Milestone

Comments

@lushkant
Copy link
Member

When exporting an empty Style Kit instead of throwing an error it gives this
{"success":true}

It's being caused in function handle_style_kit_export() at class-tools.php:355

https://github.com/mauryaratan/analogwp-templates/blob/56f281b52c8c7e432da021eddf00b8e4e5ae440f/inc/elementor/class-tools.php#L353-L355

There is no conditional check following up for this one when there is a wp_error wp_send_json_success();

Also the error throwing part can be personalized even further for users with this one right here - https://github.com/LucaRosaldi/wpfn-notifications

@lushkant lushkant added the Type: Bug Something isn't working label May 13, 2019
@lushkant lushkant added this to To do in Style Kits via automation May 13, 2019
@lushkant lushkant added this to the 1.2.1 milestone May 13, 2019
@lushkant lushkant added the Type: Feature New feature label May 13, 2019
@mauryaratan mauryaratan modified the milestones: 1.2.1, 1.2.3 May 30, 2019
@mauryaratan
Copy link
Member

Fixed in d43fe8e.

Style Kits automation moved this from To do to Done May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: Feature New feature
Projects
Style Kits
  
Done
Development

No branches or pull requests

2 participants