Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setItemMargin() disables 'scrolling up' #6

Closed
pcompassion opened this issue Jan 3, 2013 · 4 comments
Closed

setItemMargin() disables 'scrolling up' #6

pcompassion opened this issue Jan 3, 2013 · 4 comments

Comments

@pcompassion
Copy link

It worked great until I started to make it look better with setitemMargin()

The view won't scroll up once I set it. and it crashed as well.

I tested on gallaxy s2 with 2.3.3

@maurycyw
Copy link
Owner

maurycyw commented Jan 3, 2013

Can you please make sure you have the latest version of StaggeredGridView. This was a previously solved issue. I was able to test this on a 2.2.2 & 2.3.x device and it worked fine. Unfortunately I do not have any s2's nearby.

@pcompassion
Copy link
Author

I just re-cloned your git repo and retried. Same result sadly.

@yftx
Copy link

yftx commented Jan 27, 2013

I think i find the reason why pcompassion re-clone the repo and it cant scoll up.
I have tried to clone this proj , I clone it and see it was in develop branch .
and I compare the develop branch with the master branch.
there are something different in trackMotionScroll() funtion in file StaggeredGridView.java.
*trackMotionScroll() *controls the view to scroll or not scroll.
I think U will know the reason after u see the difference .

So U checkout the master branch .and then it will be scroll up fine.

@dancefire
Copy link

Confirmed yftx, just change the branch to 'master' it can scrolling up again.

@maurycyw maurycyw closed this as completed Apr 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants