Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mjml to html conversion needs the beautify option which is depreciated in browser mode #10331

Closed
adiux opened this issue Aug 13, 2021 · 3 comments
Closed

Mjml to html conversion needs the beautify option which is depreciated in browser mode #10331

adiux opened this issue Aug 13, 2021 · 3 comments
Labels
builder-grapesjs Anything related to the GrapesJS email or landing page builders enhancement Any improvement to an existing feature or functionality stale Issues which have not received an update within 90 days

Comments

@adiux
Copy link
Contributor

adiux commented Aug 13, 2021 •
edited by RCheesley

We are currently using the browser mode to convert mjml to HTML.

Html needs to be beautified for the click tracking to work. Therefore, we can not use the built-in command: mjml-get-code in order convert mjml to HTML. But we have to use mjml2html directly with the beautified option tuned on. This option is depreciated.

beautify option is deprecated in mjml-core and only available in mjml cli.

Related: #10323
@adiux adiux added needs-triage For new issues/PRs that need to be triaged builder-grapesjs Anything related to the GrapesJS email or landing page builders labels Aug 13, 2021
This was referenced Aug 13, 2021
Closed
Merged
@RCheesley RCheesley added enhancement Any improvement to an existing feature or functionality and removed needs-triage For new issues/PRs that need to be triaged labels Aug 17, 2021
@stale
Copy link

stale bot commented Nov 15, 2021

This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Nov 15, 2021
@stale
Copy link

stale bot commented Nov 29, 2021

This issue or PR has been automatically closed because it has not had recent activity. In the case of issues, if it persists in the latest version of Mautic, please create a new issue and link back to this one for reference. With PRs if you wish to pick up the PR and update it so that it can be considered for a future release, please comment and we will re-open it. Thank you for your contributions.

@stale stale bot closed this as completed Nov 29, 2021
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If this issue is continuing with the lastest stable version of Mautic, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builder-grapesjs Anything related to the GrapesJS email or landing page builders enhancement Any improvement to an existing feature or functionality stale Issues which have not received an update within 90 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RCheesley @adiux