Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import custom email template broken #12296

Closed
1 task done
TechBill opened this issue May 4, 2023 · 9 comments · Fixed by #12495 or #12680
Closed
1 task done

Import custom email template broken #12296

TechBill opened this issue May 4, 2023 · 9 comments · Fixed by #12495 or #12680
Assignees
Labels
bug Issues or PR's relating to bugs email Anything related to email regression A bug that broke something in the last release T1 Low difficulty to fix (issue) or test (PR)

Comments

@TechBill
Copy link

TechBill commented May 4, 2023

Mautic Version

4.4.x series

PHP version

8.0

What browsers are you seeing the problem on?

Chrome

What happened?

Custom email template no longer loads or renders in template editor box when a custom email template is imported.

How can we reproduce this issue?

1: Go to Contact page
2: Select a contact to send custom email
3: Click on Send Email on top of contact page
4: Select an email template from "Import from an existing template" drop down menu at bottom

After selecting an email template, the template will no longer load or render in Send Email editor box above in 4.4.8

Relevant log output

[2023-07-26 17:39:00] mautic.CRITICAL: Uncaught PHP Exception TypeError: "Mautic\CoreBundle\Helper\EmojiHelper::toEmoji(): Argument #1 ($text) must be of type string, null given, called in /var/www/html/app/bundles/EmailBundle/Helper/MailHelper.php on line 1355" at /var/www/html/app/bundles/CoreBundle/Helper/EmojiHelper.php line 23 {"exception":"[object] (TypeError(code: 0): Mautic\\CoreBundle\\Helper\\EmojiHelper::toEmoji(): Argument #1 ($text) must be of type string, null given, called in /var/www/html/app/bundles/EmailBundle/Helper/MailHelper.php on line 1355 at /var/www/html/app/bundles/CoreBundle/Helper/EmojiHelper.php:23)"} {"hostname":"mautic-web","pid":2813}

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@TechBill TechBill added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged labels May 4, 2023
@RCheesley RCheesley added this to the 4.4.9 milestone May 4, 2023 — with Slack
@RCheesley RCheesley added T1 Low difficulty to fix (issue) or test (PR) regression A bug that broke something in the last release email Anything related to email and removed needs-triage For new issues/PRs that need to be triaged labels May 4, 2023 — with Slack
@RCheesley RCheesley removed this from the 4.4.9 milestone May 31, 2023
@mautibot
Copy link

This issue has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/custom-email-to-contact-does-not-import-from-existing-template/28315/2

@shinde-rahul shinde-rahul self-assigned this Jun 16, 2023
@dsp76
Copy link

dsp76 commented Jun 18, 2023

This might be related too: #12259

@shinde-rahul
Copy link
Contributor

IMO, we should revisit the entities for M6 and remove all dead or deprecated properties. For Email, content is one property I did not see getting populated in the db when emails are created.

@RCheesley
Copy link
Sponsor Member

Found this error in 5.x and the log entry is as follows:

[2023-07-26 17:39:00] mautic.CRITICAL: Uncaught PHP Exception TypeError: "Mautic\CoreBundle\Helper\EmojiHelper::toEmoji(): Argument #1 ($text) must be of type string, null given, called in /var/www/html/app/bundles/EmailBundle/Helper/MailHelper.php on line 1355" at /var/www/html/app/bundles/CoreBundle/Helper/EmojiHelper.php line 23 {"exception":"[object] (TypeError(code: 0): Mautic\\CoreBundle\\Helper\\EmojiHelper::toEmoji(): Argument #1 ($text) must be of type string, null given, called in /var/www/html/app/bundles/EmailBundle/Helper/MailHelper.php on line 1355 at /var/www/html/app/bundles/CoreBundle/Helper/EmojiHelper.php:23)"} {"hostname":"mautic-web","pid":2813}

@RCheesley
Copy link
Sponsor Member

Hi @shinde-rahul this one is assigned to you and marked as in progress - are you still working on it?

@shinde-rahul
Copy link
Contributor

@RCheesley, #12495 is not ready for review.

@RCheesley RCheesley linked a pull request Aug 11, 2023 that will close this issue
@RCheesley
Copy link
Sponsor Member

@shinde-rahul just to be clear, did you mean that it is now ready for review? Or are you still working on it and it's not ready?

@shinde-rahul
Copy link
Contributor

@shinde-rahul just to be clear, did you mean that it is now ready for review? Or are you still working on it and it's not ready?

Yes, This is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If this issue is continuing with the lastest stable version of Mautic, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs email Anything related to email regression A bug that broke something in the last release T1 Low difficulty to fix (issue) or test (PR)
Projects
Archived in project
5 participants