Save & Close button showing & in translations

[RCheesley]

Mautic Version

5.0.x series

PHP version

8

What browsers are you seeing the problem on?

Not relevant

What happened?

Noticed this when debugging something with translations:

And also in German:

How can we reproduce this issue?

Step 1: Switch to a translation
Step 2: Notice the save & close button is not correctly formatted.

Relevant log output

No response

Code of Conduct

• I confirm that I have read and agree to follow this project's Code of Conduct

[escopecz]

This seem to be an issue with the translation itself:

mautic.core.form.saveandclose="Speichern & Schließen"

You can see that it is using just the ampersand (not URL-encoded) in the source language: https://github.com/mautic/mautic/blob/5.x/app/bundles/CoreBundle/Translations/en_US/messages.ini#L238

In Transifex:

I fixed it for the German translation in Transifex. If this issue is in other languages, please provide a list or fix it directly.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If this issue is continuing with the lastest stable version of Mautic, please open a new issue that references this one.

[mautibot]

This issue has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/mautic-5-0-3-characters-in-certain-button-labels-and-config-values-are-being-encoded/30907/3