Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment For Created User Role Doesn't Contain "**** Own" Permissions #1768

Closed
MxyzptlkFishStix opened this issue May 20, 2016 · 6 comments
Closed
Labels
ready-to-test PR's that are ready to test

Comments

@MxyzptlkFishStix
Copy link

MxyzptlkFishStix commented May 20, 2016

1

After logging in, as a user with the assigned user role, any attempt to create a segment results in the following error in the log. There are no "View Own", "Edit Own", "Create", "Delete Own" or "Publish Own" permissions.

mautic.ERROR: Fatal: Call to a member function getId() on null - in file /var/www/tools/mautic/app/bundles/EmailBundle/Entity/EmailRepository.php - at line 308

@MxyzptlkFishStix MxyzptlkFishStix changed the title Segment Permissions For Created User Role Doesn't Contain "**** Own" Options Segment For Created User Role Doesn't Contain "**** Own" Permissions May 20, 2016
@escopecz
Copy link
Sponsor Member

Segments have option in their edit page to either make them "Public Segment" (by default) or if set to "no" the segment will be accessible only for its author. So the *Own permissions are not needed.

Could you please write down the steps to recreate the error you reported? I don't think it's related to a segment since it's origin is in the EmailBundle and the segments are in LeadBundle.

@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Aug 17, 2016
@alanhartless
Copy link
Contributor

This is correct. Segments purposively do not have own permissions - it's assumed if a user has access to contacts, they can build their own lists/segments to organize those contacts.

@dongilbert
Copy link
Member

Fixed in #3627. Thanks @MxyzptlkFishStix!

@escopecz escopecz added ready-to-test PR's that are ready to test and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Mar 10, 2017
@fonderco
Copy link

fonderco commented Jun 19, 2017

I have 2.8.2 and the segment button just returns a 500 error. The user is on a custom role and has access to create, edit, delete their own contacts, but the segments button doesn't work. I know it is stated that this is fixed in #3627 but it isn't.

As soon as I edit the role to include "View Others" then the button works.

@escopecz
Copy link
Sponsor Member

@fonderco please create a new issue with all the details. Especially the error message from the logs.

@fonderco
Copy link

Actually #3724 resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test PR's that are ready to test
Projects
None yet
Development

No branches or pull requests

5 participants