Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contact to segment When contact is created #3105

Closed
kuzmany opened this issue Dec 15, 2016 · 4 comments
Closed

Add Contact to segment When contact is created #3105

kuzmany opened this issue Dec 15, 2016 · 4 comments
Labels
feature A new feature for inclusion in minor or major releases

Comments

@kuzmany
Copy link
Member

kuzmany commented Dec 15, 2016

What type of report is this:

Q A
Bug report? n
Feature request? y
Enhancement? n

Description:

New option to segments add contact to segment when is contact created

public function getCurrentLead($returnTracking = false)

Why we need this?

If we want use dynamic content we want work with contact after first visits.
Campaign need 2 crons for execute that (mautic:segments:rebuild and mautic:campaign:update)
With this option we are able to work with contacts after first touch, because is activate onLeadListChange process

public function onLeadListChange(ListChangeEvent $event)

add contact

@alanhartless
Copy link
Contributor

If memory serves me right, I believe we used to do this and backtracked because of performance. Every time a contact is created or updated, we have to loop over every (or configured in this case) segment and query to see if the filters apply to the contact. It's heavy - which becomes problematic if the contact is created during a web request such as a form submit or a page hit.

@kuzmany
Copy link
Member Author

kuzmany commented Dec 15, 2016

@alanhartless Yes, but contact is created just with first request (visits, form), maybe it's worth it.

@kuzmany
Copy link
Member Author

kuzmany commented Dec 15, 2016

@alanhartless and this option will be disabled by default.

@PatchRanger
Copy link
Contributor

Looks related to #3058 . Defintely, it could be the first step in order to go forward to #3058.

@escopecz escopecz added the feature A new feature for inclusion in minor or major releases label Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature for inclusion in minor or major releases
Projects
None yet
Development

No branches or pull requests

5 participants