Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3: Refactor Deprecations - ReportBundle #7989

Closed
22 tasks done
alanhartless opened this issue Oct 26, 2019 · 0 comments
Closed
22 tasks done

M3: Refactor Deprecations - ReportBundle #7989

alanhartless opened this issue Oct 26, 2019 · 0 comments
Assignees
@dongilbert @escopecz
Labels
ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
Mautic 3
Milestone
3.0.0-beta

Comments

@alanhartless
Copy link
Contributor

alanhartless commented Oct 26, 2019 •
edited by dongilbert

ReportBundle/Form/Type/TableOrderType.php

  • Nr. 1 line 94: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 2 line 86: Overriding deprecated method Mautic\ReportBundle\Form\Type\TableOrderType->getName()
  • Nr. 3 line 94: Overriding deprecated method Mautic\ReportBundle\Form\Type\TableOrderType->setDefaultOptions()

ReportBundle/Form/Type/DynamicFiltersType.php

  • Nr. 4 line 102: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 5 line 94: Overriding deprecated method Mautic\ReportBundle\Form\Type\DynamicFiltersType->getName()
  • Nr. 6 line 102: Overriding deprecated method Mautic\ReportBundle\Form\Type\DynamicFiltersType->setDefaultOptions()

ReportBundle/Form/Type/ConfigType.php

  • Nr. 7 line 46: Overriding deprecated method Mautic\ReportBundle\Form\Type\ConfigType->getName()

ReportBundle/Form/Type/ReportType.php

  • Nr. 8 line 288: Using deprecated class Symfony\Component\Form\Extension\Core\ChoiceList\ChoiceList
  • Nr. 9 line 448: Overriding deprecated method Mautic\ReportBundle\Form\Type\ReportType->getName()

ReportBundle/Form/Type/ReportSettingsType.php

  • Nr. 10 line 68: Overriding deprecated method Mautic\ReportBundle\Form\Type\ReportSettingsType->getName()

ReportBundle/Form/Type/AggregatorType.php

  • Nr. 11 line 93: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 12 line 85: Overriding deprecated method Mautic\ReportBundle\Form\Type\AggregatorType->getName()
  • Nr. 13 line 93: Overriding deprecated method Mautic\ReportBundle\Form\Type\AggregatorType->setDefaultOptions()

ReportBundle/Form/Type/FilterSelectorType.php

  • Nr. 14 line 159: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 15 line 151: Overriding deprecated method Mautic\ReportBundle\Form\Type\FilterSelectorType->getName()
    Nr. 16 line 159: Overriding deprecated method Mautic\ReportBundle\Form\Type\FilterSelectorType->setDefaultOptions()

ReportBundle/Form/Type/ReportWidgetType.php

  • Nr. 17 line 86: Overriding deprecated method Mautic\ReportBundle\Form\Type\ReportWidgetType->getName()

ReportBundle/Form/Type/ReportFiltersType.php

  • Nr. 18 line 53: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 19 line 37: Overriding deprecated method Mautic\ReportBundle\Form\Type\ReportFiltersType->getName()
  • Nr. 20 line 53: Overriding deprecated method Mautic\ReportBundle\Form\Type\ReportFiltersType->setDefaultOptions()
@alanhartless alanhartless added this to the 3.0.0 milestone Oct 26, 2019
@dongilbert dongilbert self-assigned this Nov 1, 2019
@alanhartless alanhartless added this to In progress in Mautic 3 Nov 1, 2019
@dongilbert dongilbert mentioned this issue Nov 1, 2019
Merged
@npracht npracht added code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Nov 1, 2019
@npracht npracht moved this from In progress to QA in Mautic 3 Nov 1, 2019
@npracht npracht added pending-feedback PR's and issues that are awaiting feedback from the author pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test and removed ready-to-test PR's that are ready to test pending-feedback PR's and issues that are awaiting feedback from the author pending-test-confirmation PR's that require one test before they can be merged labels Nov 1, 2019
@npracht npracht moved this from QA to Needs user tests in Mautic 3 Nov 3, 2019
@npracht npracht moved this from Needs user tests to QA in Mautic 3 Nov 3, 2019
@npracht npracht added pending-feedback PR's and issues that are awaiting feedback from the author and removed ready-to-test PR's that are ready to test labels Nov 3, 2019
@dongilbert dongilbert moved this from Pending Feedback to Needs code review and/or test in Mautic 3 Dec 5, 2019
@anton-vlasenko anton-vlasenko added pending-feedback PR's and issues that are awaiting feedback from the author and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Dec 6, 2019
@anton-vlasenko anton-vlasenko moved this from Needs code review and/or test to Pending Feedback in Mautic 3 Dec 6, 2019
@escopecz escopecz added the essential This must be done to close the milestone label Dec 6, 2019
@escopecz escopecz moved this from Pending Feedback to In progress in Mautic 3 Dec 13, 2019
@escopecz escopecz self-assigned this Dec 13, 2019
@escopecz escopecz removed pending-feedback PR's and issues that are awaiting feedback from the author code-review-needed PR's that require a code review before merging essential This must be done to close the milestone labels Dec 13, 2019
@escopecz escopecz added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Dec 13, 2019
@escopecz escopecz moved this from In progress to Done in Mautic 3 Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongilbert dongilbert

@escopecz escopecz

Labels
ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0-beta
Development

No branches or pull requests
5 participants
@alanhartless @dongilbert @escopecz @npracht @anton-vlasenko