Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Amazon SES API #9092

Closed
dennisameling opened this issue Aug 16, 2020 · 4 comments
Closed

Add tests for Amazon SES API #9092

dennisameling opened this issue Aug 16, 2020 · 4 comments
Assignees
@mabumusa1 @wise-gorilla
Labels
needs-automated-tests PR's that need automated tests before they can be merged
Milestone
3.1.1

Comments

@dennisameling
Copy link
Member

This issue is to track the lack of tests in #9005.

In order to make the code easier to understand for other developers and increase stability of the feature/product, I'd like to urgently ask @mabumusa1 and @wise-gorilla to add tests for the new Amazon SES API integration that's scheduled for the 3.1 release. We've already merged the feature functionality-wise into 3.1-RC so that folks can start testing in the coming week. The tests should be in before the final 3.1 release on August 24, 2020.

Please ping me if you need help/guidance, thanks in advance 🚀
@dennisameling dennisameling added the needs-triage For new issues/PRs that need to be triaged label Aug 16, 2020
@dennisameling dennisameling added this to the 3.1.0 milestone Aug 16, 2020
@dennisameling dennisameling added needs-automated-tests PR's that need automated tests before they can be merged and removed needs-triage For new issues/PRs that need to be triaged labels Aug 16, 2020
@mautibot
Copy link

This issue has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/early-access-to-amazon-ses-api-support-14x-faster-sending/12177/12

@wise-gorilla
Copy link
Contributor

Unfortuinatly i'm not familiar with writing auto test, so it would be great if anyone can help.

@RCheesley RCheesley modified the milestones: 3.1.0, 3.1.1 Aug 17, 2020
@mabumusa1
Copy link
Member

@wise-gorilla I will call you and have a couple of tests done together

@mabumusa1 mabumusa1 mentioned this issue Aug 24, 2020
Merged
@mabumusa1
Copy link
Member

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mabumusa1 mabumusa1

@wise-gorilla wise-gorilla

Labels
needs-automated-tests PR's that need automated tests before they can be merged
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
5 participants
@RCheesley @mautibot @mabumusa1 @dennisameling @wise-gorilla