Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read reciepts are not actually sent toward hangouts #44

Closed
amstan opened this issue Jan 22, 2021 · 6 comments
Closed

Read reciepts are not actually sent toward hangouts #44

amstan opened this issue Jan 22, 2021 · 6 comments

Comments

@amstan
Copy link

amstan commented Jan 22, 2021

The features checklist mentions Matrix → Hangouts / [x] Read receipts.

But I don't think this is working:

Whenever I read a recieved hangouts message from matrix, while my matrix client will have "seen" the message (matrix room no longer bolded), I don't see the same for the my avatar from hangouts (no Seen by $MyName (Hangouts) (@hangouts_5454543:example.com)).

If i load up the official hangouts, the room that I just "seen" in matrix is still bolded. My hangout friends will always think I never read their messages, despite sometimes replying.

If I "read" the new message there it will of course unbold itself in hangouts. And then in matrix I also notice my hangouts avatar update its read reciept. Seen by $MyName (Hangouts) (@hangouts_5454543:example.com) moves the last message.

Read reciepts seem to work perfectly fine toward matrix, but they don't really work toward hangouts. It's as if Seen by $MyName should perfectly follow my matrix user that it's representing.

@tulir
Copy link
Member

tulir commented Jan 22, 2021

Ether appservice -> ephemeral_events or double puppeting is required for the bridge to receive ephemeral events (read receipts, typing notifications, presence)

@amstan
Copy link
Author

amstan commented Jan 22, 2021

Got it, so then this is more of a support question instead of an actual bug. I'll try ephemeral_events and let you know (I didn't really know what it did before).

@amstan
Copy link
Author

amstan commented Jan 23, 2021

Hmm, nope. ephemeral_events doesn't seem to do anything.
Other person see that I've seen the message, Hangouts proper still has to room bolded, read reciept of the third person in the chat is still lagging behind, until I load up hangouts and "read" the message.
At that point I see this in the log:

[2021-01-23 00:15:12,768] [INFO@hangups.conversation] latest_read_timestamp for garblegarble updated to 2021-01-23 05:14:47.088011+00:00
[2021-01-23 00:15:12,768] [INFO@hangups.conversation] latest_read_timestamp for conv garblegarble participant 565465465365436543 updated to 2021-01-23 05:14:47.088011+00:00

@tulir
Copy link
Member

tulir commented Jan 23, 2021

Did you regenerate the registration and restart synapse after enabling ephemeral events?

@tohojo
Copy link

tohojo commented Jan 28, 2021

I'm not quite sure if this is related, but with ephemeral events I get this in the log:

Jan 28 18:28:39 matrix python[529465]: [2021-01-28 18:28:39,097] [ERROR@mau.as] Exception in Matrix event handler
Jan 28 18:28:39 matrix python[529465]: Traceback (most recent call last):
Jan 28 18:28:39 matrix python[529465]:   File "/opt/venvs/mautrix-hangouts/lib/python3.7/site-packages/mautrix/appservice/as_handler.py", line 178, in try_handle
Jan 28 18:28:39 matrix python[529465]:     await handler_func(event)
Jan 28 18:28:39 matrix python[529465]:   File "/opt/venvs/mautrix-hangouts/lib/python3.7/site-packages/mautrix/bridge/matrix.py", line 401, in int_handle_event
Jan 28 18:28:39 matrix python[529465]:     if self.filter_matrix_event(evt):
Jan 28 18:28:39 matrix python[529465]:   File "/opt/venvs/mautrix-hangouts/lib/python3.7/site-packages/mautrix_hangouts/matrix.py", line 160, in filter_matrix_event
Jan 28 18:28:39 matrix python[529465]:     return (evt.sender == self.az.bot_mxid
Jan 28 18:28:39 matrix python[529465]: AttributeError: 'ReceiptEvent' object has no attribute 'sender'

@amstan
Copy link
Author

amstan commented Feb 8, 2021

I'm not quite sure if this is related, but with ephemeral events I get this in the log:

Same, i just regenerated my registration and was greeted by these errors.
They seem harmless.

FWIW this bug is still ongoing, my hangouts still has bolded rooms.

@tulir tulir closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants