Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dependency on setuptools #57

Closed
0-wiz-0 opened this issue Jan 5, 2022 · 1 comment
Closed

Unnecessary dependency on setuptools #57

0-wiz-0 opened this issue Jan 5, 2022 · 1 comment

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Jan 5, 2022

setup.py includes setuptools in its install_requires (via requirements.txt).

As far as I can tell, setuptools is not used after installation, so this should be put in setup_requires or just removed.

@tulir
Copy link
Member

tulir commented Jan 5, 2022

https://github.com/mautrix/googlechat/blob/master/mautrix_googlechat/web/auth.py#L18 (the dependency should be removed eventually, but I haven't found any simple way to replace pkg_resources.resource_filename)

@tulir tulir closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants