fix: root should not add any observers

maverick-js · Nov 25, 2022 · 36baad2 · 36baad2
1 parent 20aa37e
commit 36baad2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/observables.ts b/src/observables.ts
@@ -86,7 +86,7 @@ if (__DEV__) {
 export function root<T>(fn: (dispose: Dispose) => T): T {
   const $root = () => {};
   $root[SCOPE] = currentScope;
-  return compute($root, () => fn(() => dispose($root)));
+  return compute($root, () => fn(() => dispose($root)), undefined);
 }
 
 /**
@@ -191,7 +191,7 @@ export function computed<T>(fn: () => T, options?: ComputedOptions<T>): Observab
 
         $computed[CONTEXT]?.[ERROR]?.clear();
 
-        const nextValue = compute($computed, fn);
+        const nextValue = compute($computed, fn, $computed);
         if (isDirty(currentValue, nextValue)) {
           currentValue = nextValue;
           dirtyNode($computed);
@@ -425,7 +425,7 @@ export function dispose(fn: () => void) {
 function compute<T>(
   scope: (() => void) | undefined,
   node: () => T,
-  observer: (() => void) | undefined = scope,
+  observer: (() => void) | undefined,
 ): T {
   const prevScope = currentScope;
   const prevObserver = currentObserver;

diff --git a/tests/root.test.ts b/tests/root.test.ts
@@ -8,6 +8,7 @@ import {
   type Observable,
   type ObservableSubject,
 } from '../src';
+import { OBSERVED_BY, OBSERVING } from '../src/symbols';
 
 afterEach(() => tick());
 
@@ -100,3 +101,12 @@ it('should hold parent tracking', async () => {
     });
   });
 });
+
+it('should not observe', () => {
+  const $a = observable(0);
+  root(() => {
+    $a();
+    expect(getScope()![OBSERVING]).toBeUndefined();
+    expect(getScope()![OBSERVED_BY]).toBeUndefined();
+  });
+});