fix: clear error handlers before each computed run

maverick-js · Nov 25, 2022 · 8a716cd · 8a716cd
1 parent 58df985
commit 8a716cd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/observables.ts b/src/observables.ts
@@ -189,6 +189,8 @@ export function computed<T>(fn: () => T, options?: ComputedOptions<T>): Observab
           $computed[DISPOSAL].clear();
         }
 
+        $computed[CONTEXT]?.[ERROR]?.clear();
+
         const nextValue = compute($computed, fn);
         if (isDirty(currentValue, nextValue)) {
           currentValue = nextValue;

diff --git a/tests/onError.test.ts b/tests/onError.test.ts
@@ -64,7 +64,7 @@ it('should not duplicate error handler', async () => {
   root(() => {
     effect(() => {
       $a();
-      onError(handler);
+      onError(() => handler());
       if (shouldThrow) throw error;
     });
   });