Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guidelines #33

Closed
PalmDevs opened this issue Apr 9, 2023 · 9 comments
Closed

Add contribution guidelines #33

PalmDevs opened this issue Apr 9, 2023 · 9 comments

Comments

@PalmDevs
Copy link
Contributor

PalmDevs commented Apr 9, 2023

It should tell what naming convention to use and where. So far, I've seen parameter names being inconsistent as well as the parent class names (for OO languages).

I'd suggest making contributors use the language's casing style for method/function names. Eg. for JS use camelCase and for Python use snake_case.

@mawerty
Copy link
Owner

mawerty commented Apr 9, 2023

I have updated README file. Now it is okay, or did I forget something/did something wrong?

@Acters
Copy link

Acters commented Apr 9, 2023

Making the function take the smallest amount of space/data in memory will be the most optimized approach.

@Acters
Copy link

Acters commented Apr 9, 2023

To clarify someone asked something like this in StackOverflow https://stackoverflow.com/questions/21757755/what-in-the-function-is-occupying-memory-space

@mawerty
Copy link
Owner

mawerty commented Apr 9, 2023

The most optimized approach is one that works, and takes least space.

@Acters
Copy link

Acters commented Apr 9, 2023

Guidelines should demand that the assembly output of a compiled language should match the assembly code in the repository.

@mawerty
Copy link
Owner

mawerty commented Apr 9, 2023

Yeah, but then the code would be too complicated and not that fun.

@Acters
Copy link

Acters commented Apr 9, 2023

I thought the idea of this was to create an O(1) time complexity that translates to 1 instruction cycle of the CPU. How do all different languages compare to the true assembly approach of XOR eax, eax? Are we truly reaching O(1) time complexity if the code is not fine tuned to match the desired Assembly output?

@mawerty
Copy link
Owner

mawerty commented Apr 9, 2023

O(1) means that regardless of the number we ask for, the execution time of our program will be constant and always the same

@PalmDevs
Copy link
Contributor Author

The current one looks okay to me. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants