Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing through errors from underlying streams #16

Open
DamonOehlman opened this issue Mar 23, 2015 · 1 comment
Open

Passing through errors from underlying streams #16

DamonOehlman opened this issue Mar 23, 2015 · 1 comment

Comments

@DamonOehlman
Copy link

Been using multiplex for a while and loving it, but I'm not sure that stream error handling is well dealt with by the package. This hasn't been a problem before, but recently WebRTC data channels have been popping up edge cases that are giving my error handling a really solid run.

With some tinkering I found that modifying line 107 to the following code:

decode.pipe(through.obj(decoder)).on('error', dup.emit.bind(dup, 'error'))

the problem goes away but I'm not sure that is all that is required to ensure that unhandled errors in the local streams are bubbled up to a place in which they can be handled.

Any thoughts on what the right way to handle this is before I go all gangbusters with a PR?

@mafintosh
Copy link
Collaborator

Could you try v6.0.0 and see if that is still an issue? It uses a different wire protocol so make sure to update it on both ends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants