Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dvorak Keyboard Layout #27

Closed
dominicbarnes opened this issue Jan 28, 2013 · 4 comments
Closed

Support for Dvorak Keyboard Layout #27

dominicbarnes opened this issue Jan 28, 2013 · 4 comments

Comments

@dominicbarnes
Copy link

After searching, I already found that AZERTY layout support was added via #23.

Now I'm wondering if I just want hard-coded support for Dvorak as well, or if keybindings makes sense as either a configurable option, or a separate module altogether. I'd like to make these changes myself and submit it as a PR, but not before asking what the preferred direction should be.

Cheers

@max-mapper
Copy link
Owner

heya - thanks for asking. I think a module for key bindings would be awesome. it can probably also generic, there might already be something out there for this. the relevant code is:

https://github.com/maxogden/voxel-engine/blob/master/index.js#L64
and each key emits 'command' https://github.com/maxogden/voxel-engine/blob/master/index.js#L678

I would ideally like to see the bindWASD module get replaced by something external with an option that you pass in to game specifying your keyboard layout. also for layout selecting UI something like http://code.google.com/p/dat-gui/ could be nice and slick

@dominicbarnes
Copy link
Author

Alright, I'll start playing around with this and see what I can come up with.

@Goutte
Copy link
Contributor

Goutte commented Jan 29, 2013

Hacking in the support for AZERTY prompted this question too in my head. I'm eager to see what you come up with, because my js-fu was not strong enough to find a solution out of thin air.

Good luck !

@YenTheFirst
Copy link
Contributor

here's my initial swing at it:
https://github.com/YenTheFirst/voxel-engine/tree/custom_controls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants