New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"stream" vs "connection" #77

Open

gritzko opened this issue Dec 5, 2015 · 1 comment

gritzko commented Dec 5, 2015

https://github.com/maxogden/websocket-stream/blob/master/server.js#L18

FYI, we had to do the opposite trick: "connection" is a standard event we expect from a server, so
https://github.com/gritzko/stream-url-ws/blob/master/index.js#L21

Probably you should emit both?

egirshov commented Dec 5, 2015

The server already emits both "connection" event (with a plain websocket) and a custom "stream" event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment