Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention vcpkg package #29

Closed
mheyman opened this issue May 28, 2021 · 4 comments
Closed

mention vcpkg package #29

mheyman opened this issue May 28, 2021 · 4 comments

Comments

@mheyman
Copy link

mheyman commented May 28, 2021

In the Using the library section, you can mention that atomic_queue is available via vcpkg. For example:

$ ./vcpkg install atomic-queue

FYI: the vcpkg port is pretty simple: https://github.com/microsoft/vcpkg/tree/master/ports/atomic-queue

@max0x7ba
Copy link
Owner

max0x7ba commented May 28, 2021

Added that to the documentation, thank you.

IMO, it would be least surprising if vcpkg port had exactly the same name - atomic_queue (with an underscore, not a dash).

@mheyman
Copy link
Author

mheyman commented May 28, 2021

Yes, it would be less surprising. Unfortunately, vcpkg is opinionated about package names and doesn't allow underscores :-(

@max0x7ba
Copy link
Owner

Yes, it would be less surprising. Unfortunately, vcpkg is opinionated about package names and doesn't allow underscores :-(

Oh, I didn't know that.

@max0x7ba max0x7ba reopened this May 30, 2021
@max0x7ba
Copy link
Owner

max0x7ba commented Jun 29, 2023

In the Using the library section, you can mention that atomic_queue is available via vcpkg. For example:

$ ./vcpkg install atomic-queue

FYI: the vcpkg port is pretty simple: https://github.com/microsoft/vcpkg/tree/master/ports/atomic-queue

vcpkg_from_github parameters REF and SHA512 refer to an old version and that concerns me.

I am unfamiliar with vcpkg and unsure what these parameters are used for. Reading vcpkg_from_github documentation, these parameters are optional. Would it make sense to remove them, so that your port tracks the latest version from master/HEAD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants