Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for selection's actual appearance #4

Closed
MaxArt2501 opened this issue Jun 24, 2017 · 0 comments
Closed

Check for selection's actual appearance #4

MaxArt2501 opened this issue Jun 24, 2017 · 0 comments
Assignees
Labels

Comments

@MaxArt2501
Copy link
Owner

It may happen that a selection may comprise just white space that gets collapsed, thus producing no visible selection. This leads to range.getClientRects() to produce an empty array of rects, so the library has no way to position the popover.

It may happen whn double-clicking outside the area that triggers the popover, or by modifiying the existing selection.

A check has to be performed on the constrained range prior to re/draw the popover.

@MaxArt2501 MaxArt2501 added the bug label Jun 24, 2017
@MaxArt2501 MaxArt2501 self-assigned this Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant