Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture width is used as height #2

Closed
TheMadDodger opened this issue Jan 7, 2020 · 3 comments
Closed

Texture width is used as height #2

TheMadDodger opened this issue Jan 7, 2020 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@TheMadDodger
Copy link

A typo in MA_TextureUtils.cs on line 44 causes the copied texture to be the wrong size if the height is different from the width, this is the second time I had to fix this myself as updating it to the latest version still includes this exact same typo.

Texture2D myTexture2D = new Texture2D(texture.width, texture.width);
should be:
Texture2D myTexture2D = new Texture2D(texture.width, texture.height);

Please test your tool before uploading/updating it!!!

Also a suggestion: the exporting of the textures happens to one single folder, would be nice if you get a prompt to select where you want to save the textures, or maybe even have the path in the export settings.

@TheMadDodger
Copy link
Author

Also, the tool has compiler errors when you try to make a build.

@maxartz15 maxartz15 self-assigned this Jan 14, 2020
@maxartz15 maxartz15 added bug Something isn't working enhancement New feature or request labels Jan 14, 2020
@maxartz15
Copy link
Owner

A typo in MA_TextureUtils.cs on line 44 causes the copied texture to be the wrong size

Thanks for finding this bug, I think the main reason why I haven't found it yet is because I only used squared textures with this tool.

Also, the tool has compiler errors when you try to make a build.

Forgot to include the define #if UNITY_EDITOR in MA_TextureAtlasserProExportSettings.cs, this should now be fixed as well.

Version 1.7.3 is now available to test.
https://github.com/maxartz15/MA_TextureAtlasser/releases/tag/1.7.3

@maxartz15
Copy link
Owner

maxartz15 commented Jan 14, 2020

Also a suggestion: the exporting of the textures happens to one single folder, would be nice if you get a prompt to select where you want to save the textures, or maybe even have the path in the export settings.

Thanks for the suggestion, I will be looking at this for the next version. If you could open a new issue for this, that would be great. (then I can close this one.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants