Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve estimated_step #373

Closed
huangzhiyong opened this issue Jul 12, 2021 · 2 comments · Fixed by #376
Closed

improve estimated_step #373

huangzhiyong opened this issue Jul 12, 2021 · 2 comments · Fixed by #376

Comments

@huangzhiyong
Copy link
Contributor

func get_chunks_for_table is used to calculate the size of each chunk. In some special cases, the value of estimated_step (estimated_step = (nmax - nmin) / estimated_chunks + 1) will be very large. It is recommended to add a global parameter. When estimated_step is greater than the global parameter, the block size will use the global parameter.

@davidducos
Copy link
Member

Hi @huangzhiyong , 100% agree with you!! I saw this in the past but didn't find the time to work on a solution. I really appreciate if you can add the code needed, if not, don't worry I will do it for next release. BTW, I would like to use estimated_step as the name of the global variable and change to: local_estimated_step = (nmax - nmin) / estimated_chunks + 1) for the function calculation.

@davidducos davidducos added this to the Release 0.10.9 milestone Jul 12, 2021
huangzhiyong added a commit to huangzhiyong/mydumper that referenced this issue Jul 13, 2021
@huangzhiyong
Copy link
Contributor Author

Hi @davidducos, C is not my strong point, I tried to push a RP #376

@davidducos davidducos linked a pull request Jul 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants