mydumper: fix an 'SQL injection' issue when table name contains a ' or \ #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `detect_generated_fields()` and `get_insertable_fields()`, the query was constructed by `printf`ing the database and table names without escaping. When these names contain a `'` or `\`, the query would become invalid. This PR fixes the issue by switching to use prepare statements, so that the SQL engine could automatically escape these strings.
davidducos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
detect_generated_fields()andget_insertable_fields(), the query was constructed byprintfing the database and table names without escaping. When these names contain a'or\, the query would become invalid.This PR fixes the issue by switching to use prepare statements, so that the SQL engine could automatically escape these strings.