-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding config file functionality #370
Conversation
The variables set in the file will be the latest to load, which means that it will get precedence from the parameters list in the execution line. |
Generally, command line option values overrule matching config-file option values, For group names, maybe support a layered structure, such that [myloader_foo] is a specialization of the [myloader] settings. This also assumes that one can specify the group name suffix in the command. |
I will check how hard it is going to be to change the variable loading order, tbh I didn't think that it would matter. Take into account that we use the config file, as other tools like Proxysql or Pxc scheduler handler, which keep different groups depending what your configuring. What we are doing differently, is that we allow to keep the config for both tools: mydumper and myloader. Please let me know if this clarifies the goal and it does or does not make sense to you |
This PR is adding 2 features:
1- Load the parameters from a file on group section [myloader] and [mydumper]
2- Load the set session variables from [mydumper_variables] and [myloader_variables]