New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Add Ruby Utility to Help Write Ruby Commands More Naturally #12
Open
rogerluan
wants to merge
23
commits into
maxchuquimia:master
Choose a base branch
from
rogerluan:refactor-ruby-commands
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages # Conflicts: # Sources/XCGrapherLib/XCGrapher.swift
This is great! Happy for you to merge - I've added you as a collaborator (I think that's what you mean? I haven't really used Github with other people much hahaha) |
maxchuquimia
approved these changes
Sep 11, 2021
Thank you! 💪 Since this PR is already up from a fork, I'll leave the things as is for now, and only merge it in once the base PR has been merged 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make writing Ruby commands more naturally, in a script-like way, instead of dealing with those awkward CLI syntax.
I thought of opening a separate PR for this feature since it may not be a desired change 🤷 If that's the case, we can easily and simply close this PR 👍
Discussion
Sorry for piling follow up PRs on top of open PRs 😆 This branch was branched off of #10
@maxchuquimia if you'd like to invite me as a member/co-owner of this repo, these branches can be managed more easily by me (so they point to the right branch instead of all pointing to master, which makes them look completely unrelated 😬 ). Your call though, don't worry if not 😊