Add Support to --package path/to/Package.swift Parameter
#7
Conversation
…pport # Conflicts: # Sources/XCGrapherLib/XCGrapher.swift
There was a problem hiding this comment.
Thanks for this! I'm surprised the swift build stuff actually works, was worried there might need to be handling around the OSes that the package supports.
It's a little difficult to read through the code whilst the other PR is still open, so I'll want to go through it again once it is merged - but looking good!
And, we will need new tests that specifically target a package as a starting point I reckon.
| @@ -76,6 +76,7 @@ private enum KnownEdges { | |||
| ("SomePackage", "Kingfisher"), | |||
| ("SomePackage", "Moya"), | |||
| ("Moya", "Alamofire"), | |||
| ("SomePackage", "Alamofire"), | |||
There was a problem hiding this comment.
I know you said you did this to make the tests graph more interesting - but I specifically chose Moya because I knew it was dependent on Alamofire and that way we could properly test that dependencies of dependencies are discovered. Would prefer to revert it back to the way it was as in this case we could introduce a bug where only direct dependencies of the starting point are discovered!
There was a problem hiding this comment.
I'm happy to remove Alamofire direct dependency, but I'd like to introduce enough dependencies to replicate this behavior:
(2 arrows coming to the same dependency)
Can you think of other packages that we could achieve this? 😁
There was a problem hiding this comment.
Maybe we could simply add https://github.com/apple/swift-algorithms? It seems to be dependent on https://github.com/apple/swift-numerics - then we could just keep your changes of adding Alamofire, easy peasy
There was a problem hiding this comment.
Can we re-evaluate this on (or after) #10? 🙏 I've changed quite a lot of things between this PR and that one, so fixing in both would be kind of a mess. I reckon I could've fixed it earlier, but I've been working on that branch for quite some time already 😅 Hope you're cool with that 👍
There was a problem hiding this comment.
Yup we can - should we hold off merging until then too, or do you prefer it to merge before #10?
There was a problem hiding this comment.
Ah now I see in #10 that you would like this merged first 🎉
|
Thanks for merging this in @maxchuquimia ! 🎉 🚀🚀 |
Description
This PR picks up the work that was initiated here d04da28 and aims to bring support for the
--packageargument, which receives a path to a Package.swift file, and plots a graph for the dependencies of the given Swift Package.The heavy lifting was really done by @maxchuquimia. What I did was finish up the TODO left here d04da28#diff-153d5429d399c18d0a6dd32f593f6d1411fd0c8e9df19e62701497835913edb9R31 and fix the unit tests. I also added a new dependency to the sample SPM project to make the resulting graph look more interesting (where 2 packages (SomePackage and Moya) depends on the same dependency (Alamofire).
Resolves #4
Note: this PR was branched off of #6 so please review & possibly merge it first, before reviewing & merging this one. As I'm working off of a GitHub Fork, I can't point this PR against my other branch 😬
Demo