version 0.10.3 broke SemVer guarantees

[qrilka]

• I have looked for existing issues (including closed) about this

Bug Report

Version 0.10.3 added lifetime parameter to SessionManager - https://docs.rs/tower-sessions/latest/tower_sessions/service/struct.SessionManager.html
As per https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-parameter-no-default this is a Major change and yet only a patch version was released
This e.g. breaks builds of axum-login

Version

$ cargo tree | grep tower-sessions
│   ├── tower-sessions v0.10.3
│   │   ├── tower-sessions-core v0.10.3
│   │   ├── tower-sessions-memory-store v0.10.3
│   │   │   └── tower-sessions-core v0.10.3 (*)

Platform

$ uname -a
Linux qdell-7080 6.5.0-14-generic #14~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Mon Nov 20 18:15:30 UTC 2 x86_64 GNU/Linux

Crates

Description

As specified, failed in a project depending on axum-login-0.13

[maxcountryman]

As per the tests, no code changes should be required even with this change.

Note that this introduces a lifetime, where one should already but implicit, not a type parameter; lifetimes do not appear to be listed as breaking semver minor updates (but perhaps they should be).

Please provide a breaking test case or example so we can investigate.

[maxcountryman]

This seems like it demonstrates the issue: maxcountryman/axum-login#189

[maxcountryman]

The release is yanked so that closes this ticket.

That said, we'll put together a new release either hardcoding the static lifetime or incrementing the minor version.