Support playback with colors #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract RGB information from scaled image and stylize each character with its color info.
Update charmaps to better handle the colorization.
Outstanding issues to consider:
- Use only solid blocks when using colors?
Default ASCII charmap is fine, can switch to solid block after. Other defaults tbc.
- Allow characters, but the issue is that default char map is chosen to quantize grayscale/luminance. How would it look like when RGB colors (which already contains luminance information) are applied?
Unresolved, just select the char map that makes it look best for you
- Add command line flag (color or grayscale by default?)
Default is color (is a media player, after all), grayscale with flag and live-toggle
- Will grayscale images/videos work?
I couldn't find any media that didn't work. More test will be needed on a variety of media files