Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tracking source location for error reporting #25

Closed
MaxDesiatov opened this issue Jun 5, 2019 · 1 comment
Closed

Support tracking source location for error reporting #25

MaxDesiatov opened this issue Jun 5, 2019 · 1 comment
Assignees
@hodovani
Projects
0.1 release

Comments

@MaxDesiatov
Copy link
Owner

MaxDesiatov commented Jun 5, 2019 •
edited
Loading

This requires adding var position: AbsolutePosition { get } property to the Statement protocol. AbsolutePosition is defined in the SwiftSyntax module. enum Expr should no longer conform to Statement, but should be wrapped as a property of struct ExprNode: Statement, which would allow attaching position to expressions. Other types conforming to Statement will require adding let position: AbsolutePosition stored property to them.
@MaxDesiatov MaxDesiatov self-assigned this Jun 5, 2019
@MaxDesiatov MaxDesiatov added this to To do in 0.1 release via automation Jun 5, 2019
@MaxDesiatov MaxDesiatov assigned hodovani and unassigned MaxDesiatov Jun 6, 2019
@MaxDesiatov MaxDesiatov mentioned this issue Jun 6, 2019
Closed
@MaxDesiatov MaxDesiatov moved this from To do to Done in 0.1 release Jun 7, 2019
@MaxDesiatov
Copy link
Owner Author

Implemented in #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hodovani hodovani

Labels
None yet
Projects
No open projects
0.1 release
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaxDesiatov @hodovani