Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod parsing - Small bug regarding a helmet enchant #26

Open
drevtpohlman opened this issue Oct 3, 2023 · 1 comment
Open

Mod parsing - Small bug regarding a helmet enchant #26

drevtpohlman opened this issue Oct 3, 2023 · 1 comment
Labels
bad parsing Bad or missing parsing

Comments

@drevtpohlman
Copy link

drevtpohlman commented Oct 3, 2023

The "Spark fires 3 additional projectiles" enchant is being ignored while price-checking, while other enchants seem to work just fine.

I think the issue here is the difference in the wording used on the official trade site to search for this enchant, which is "spark fires an additional projectile" with the minimum value set to 3, rather than "spark fires # additional projectiles" like what some might expect.

There could be more discrepancies in search terms on the official site causing enchants/mods to be omitted, but this is just one that I noticed.

Screen of spark enchant and its overlay:
image

Screen of another random enchant and its overlay:
image

I've also added the Ctrl+C data of the helm with the spark enchant if it helps:

Item Class: Helmets
Rarity: Magic
Virile Deicide Mask of the Starfish
--------
Quality: +20% (augmented)
Evasion Rating: 262 (augmented)
Energy Shield: 65 (augmented)
--------
Requirements:
Level: 67
Dex: 73
Int: 88
--------
Sockets: B 
--------
Item Level: 92
--------
Spark fires 3 additional Projectiles (enchant)
--------
+73 to maximum Life
Regenerate 17.3 Life per second

@maxensas
Copy link
Owner

maxensas commented Oct 3, 2023

Hi, thanks for your report. It's appreciated.

We already identified this issue exactly like you describe.
It exist since 2/3 leagues i would say when GGG did an update to their filters.
I already started to work on a new algorythm to identify thoses mods dynamically in all languages, not just english instead of parsing them one by one (see ParsingRules.json file) and inject the numeric value in input that we do not have on the mod recognized by the trade website.

@maxensas maxensas changed the title Small bug regarding a helmet enchant Mod parsing - Small bug regarding a helmet enchant Oct 3, 2023
@maxensas maxensas added the bad parsing Bad or missing parsing label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad parsing Bad or missing parsing
Projects
None yet
Development

No branches or pull requests

2 participants