Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM suppport #121

Merged
merged 1 commit into from
Jul 15, 2020
Merged

SPM suppport #121

merged 1 commit into from
Jul 15, 2020

Conversation

kenji21
Copy link
Contributor

@kenji21 kenji21 commented May 15, 2020

Description

Added Package.swift file

Motivation and Context

integrate this nice piece of code using SPM

How Has This Been Tested?

building it with xed . in repo folder to open the Package.swift "pseudo-project" with in Xcode

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@kenji21
Copy link
Contributor Author

kenji21 commented May 15, 2020

related to issue #116

@stale
Copy link

stale bot commented Jul 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2020
@kenji21
Copy link
Contributor Author

kenji21 commented Jul 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

:/

@stale stale bot removed the stale label Jul 15, 2020
Copy link
Owner

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kenji21 👍

@maxep maxep merged commit 095ec37 into maxep:master Jul 15, 2020
@kenji21
Copy link
Contributor Author

kenji21 commented Jul 15, 2020

One more step in order to have an Xcode project find MXParallaxHeader to be found : it needs a new tag, maybe 1.1.0 should be chosen

@Drusy
Copy link

Drusy commented Jul 29, 2020

Any plan to tag/release this @maxep ?
We now have to target the master branch to use SPM, would be nicer using a release !

@Drusy
Copy link

Drusy commented Jul 29, 2020

Spoke too fast, using the master branch results in missing headers for Swift projects
Umbrella directory '~/Library/Developer/Xcode/DerivedData/Template-fhwdlwrvaxparjdwvnikcfyarzff/SourcePackages/checkouts/MXParallaxHeader/Sources/include' not found

@kenji21
Copy link
Contributor Author

kenji21 commented Jul 29, 2020

Just made a second PR to fix this : #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants