-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SPM Usage in Xcode 12.5+ #126
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is a PR, it's not stale π’ |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still valid |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still valid. |
@maxep could this PR be reviewed any time? π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rogerluan
Thank you for your contribution! Tho, I'm no longer maintaining this project, cf. #124
Which mean that I won't be publishing new versions. I would be happy to add you as a collaborator to this project if you want to manage the merging and the release, so anyone can benefit from your contribution.
Otherwise, we can keep this PR open for reference.
Let me know :)
@maxep hi!π feel free to add me as a contributor! Happy to move things forward :) |
@rogerluan, super nice, thank you! So I've added you as a collaborator on this project. I've tried to add your email (from your GH profile) to cocoapods, but it seems that you are not yet registered. Could you please register? π https://guides.cocoapods.org/making/getting-setup-with-trunk.html#getting-started Thanks again! |
I'll do that tomorrow! π€ |
Done @maxep ! :) Same email as my GH profile |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
On Xcode 12.5, apparently the umbrella header generation logic changed, so this stopped working on my project because my project couldn't find
MXScrollView
anymore, when importing this lib using SPM. The problem was that the generated umbrella header didn't contain references to all the public headers. This PR aims to fix that.Motivation and Context
How Has This Been Tested?
It compiles on my project now π
Before:
Now, the same code above compiles just fine.
Types of changes
Checklist: