Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM Usage in Xcode 12.5+ #126

Closed
wants to merge 1 commit into from
Closed

Conversation

rogerluan
Copy link
Collaborator

Description

On Xcode 12.5, apparently the umbrella header generation logic changed, so this stopped working on my project because my project couldn't find MXScrollView anymore, when importing this lib using SPM. The problem was that the generated umbrella header didn't contain references to all the public headers. This PR aims to fix that.

Motivation and Context

How Has This Been Tested?

It compiles on my project now πŸ˜„

Before:

import MXParallaxHeader
…
let scrollView = MXScrollView // Couldn't find reference to MXScrollView

Now, the same code above compiles just fine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. - Nope
  • I have updated the documentation accordingly. - There's no need to update anything

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2022
@rogerluan
Copy link
Collaborator Author

This is a PR, it's not stale 😒

@stale stale bot removed the stale label Jan 5, 2022
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 17, 2022
@rogerluan
Copy link
Collaborator Author

Still valid

@stale stale bot removed the stale label Apr 18, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 10, 2022
@rogerluan
Copy link
Collaborator Author

Still valid.

@rogerluan
Copy link
Collaborator Author

@maxep could this PR be reviewed any time? πŸ™‡

@stale stale bot removed the stale label Jul 10, 2022
@maxep maxep self-requested a review July 11, 2022 16:51
Copy link
Owner

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogerluan

Thank you for your contribution! Tho, I'm no longer maintaining this project, cf. #124
Which mean that I won't be publishing new versions. I would be happy to add you as a collaborator to this project if you want to manage the merging and the release, so anyone can benefit from your contribution.

Otherwise, we can keep this PR open for reference.

Let me know :)

@rogerluan
Copy link
Collaborator Author

@maxep hi!πŸ‘‹ feel free to add me as a contributor! Happy to move things forward :)
Just make sure I have enough permissions to publish releases (and maybe pods?), so I don't have to bother you again πŸ˜„ cheers!

@maxep
Copy link
Owner

maxep commented Jul 13, 2022

@rogerluan, super nice, thank you!

So I've added you as a collaborator on this project. I've tried to add your email (from your GH profile) to cocoapods, but it seems that you are not yet registered. Could you please register? πŸ‘‰ https://guides.cocoapods.org/making/getting-setup-with-trunk.html#getting-started

Thanks again!

@rogerluan
Copy link
Collaborator Author

I'll do that tomorrow! πŸ€—

@rogerluan
Copy link
Collaborator Author

Done @maxep ! :) Same email as my GH profile

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@stale stale bot closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants