Is CrossUniformFloat64 correct?

[spakin]

I was just looking at the source code for CrossUniformFloat64, and I'm a bit puzzled by it. It assigns p1[i] a proportion of each of the old p1[i] and the old p2[i], but then it assigns p2[i] a proportion of each of the new p1[i] and the old p2[i]. Shouldn't it be using some intermediate variables to correctly distribute the parents' values to the children?

[MaxHalford]

Hey there @spakin! I don't work on eaopt actively anymore, and I don't have the bandwidth to look into this at the present time. The best thing to do would be to check yourself and/or write some kind of unit test :)

[spakin]

@MaxHalford: I checked, and the problem is manifested by CrossUniformFloat64 not preserving the total value from parents to offspring. In pull request #47, the code first computes the two new values and then assigns them to p1[i] and p2[i]. I correspondingly updated the unit tests to check for the old, bad behavior.

[MaxHalford]

Cheers! Nice and sweet PR. It makes me want to give some love back to the library.