New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colors to cli messages #11
Conversation
Zebralt! Thanks for your contribution. Unfortunately, hickory has an aversion to and does not want take on any third party dependencies (that's my bad, I should have made this clear in the issue) Do you think we could rewrite the the colouring functions with something like this: https://stackoverflow.com/a/58149095/3731467? Otherwise, the rest of the code fixes you've added are solid 👍 |
Yeah, I can do that. I'll just replace the colorama imports with custom ones. If you ever want to bring colors to Windows though, colorama is probably your best bet since there's a whole part of the package that is dedicated to translate escape sequences into Windows calls. Not that I'm a Windows fanboy or anything of the like :P |
@maxhumber |
Related issue: #5
Here's what this PR brings:
Killed X
,Scheduled X
);os.isatty
and not add any colors).hickory/__main__.py
to be able to run the package against a specific python runtime:python -m hickory
targeting the folder or the installed package.Coloring is done using colorama, a popular terminal coloring package. It also brings cross-compatibility with Windows since coloring is done through API calls rather than escape sequences in there.