Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to set width for Avatar with DC #5562

Closed
kyrapieterse opened this issue Apr 22, 2024 · 2 comments · Fixed by #5690
Closed

No way to set width for Avatar with DC #5562

kyrapieterse opened this issue Apr 22, 2024 · 2 comments · Fixed by #5690
Assignees
Labels
bug 🐛 Something isn't working bug fse

Comments

@kyrapieterse
Copy link
Contributor

kyrapieterse commented Apr 22, 2024

Description

Max width for the avatar in maxi and author blocks is 96x96. Avatar block allows up to 240px

image
image

Step-by-step reproduction instructions

Add DC avatar and Avatar block, compare the max size.

Screenshots, screen recording, code snippet

No response

URL and/or Code editor

No response

How to fix it

Check how the Avatar block gets bigger image from gravatar

Other information

No response

@dosubot dosubot bot added the bug 🐛 Something isn't working label Apr 22, 2024
@elzadj elzadj changed the title No way to set the Avatar with DC No way to set width for Avatar with DC Apr 24, 2024
@myroslavve myroslavve self-assigned this Aug 8, 2024
@myroslavve
Copy link
Collaborator

I have two options for this issue:

  1. Add a slider to enable users to select avatar size:
    image

  2. Load the biggest size image, unless width for an image block is set. If the width is set, then load the image with size 2 times the width, like gutenberg avatar block does.

If I do the second option the loaded image will be larger than necessary on average, but the user won't have to think about it unlike the first option. Not sure which is better in this situation.

@myroslavve
Copy link
Collaborator

Decided to go with the first option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working bug fse
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants