Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add support for CPT templates #5587

Closed
Olekrut opened this issue May 17, 2024 · 6 comments · Fixed by #5645
Closed

Need to add support for CPT templates #5587

Olekrut opened this issue May 17, 2024 · 6 comments · Fixed by #5645

Comments

@Olekrut
Copy link
Collaborator

Olekrut commented May 17, 2024

Description

image
Backend:
image
Frontend:
image

acf-export-2024-05-17.json

Other plugins or websites examples

No response

How to implement it

No response

Other information

No response

@elzadj
Copy link
Collaborator

elzadj commented May 31, 2024

Looks like the issue has 2 parts - plugin fix (looks like the styles are not working?) and then adding our template to our theme.
Let's first do the plugin fix here, and move our CPT template to the theme github maxi-blocks/maxiblocks-theme#3

@myroslavve
Copy link
Collaborator

Seems to be fixed on master for me @Olekrut, can you check please

@Olekrut
Copy link
Collaborator Author

Olekrut commented Jun 24, 2024

@myroslavve looks like frontend is ok now, but not backend
https://jam.dev/c/0c87a163-2344-4b83-8d3d-c4bb44a6e32d

@myroslavve
Copy link
Collaborator

@myroslavve looks like frontend is ok now, but not backend https://jam.dev/c/0c87a163-2344-4b83-8d3d-c4bb44a6e32d

Can't reproduce this

@elzadj
Copy link
Collaborator

elzadj commented Jun 27, 2024

@myroslavve looks like frontend is ok now, but not backend https://jam.dev/c/0c87a163-2344-4b83-8d3d-c4bb44a6e32d

Can't reproduce this

Can't reproduce it too, but the DC - Current item on a 'Single Project' template gives me an error (it works tho, but we need to fix it anyway, and check all possible current items - title, content, author, date, etc.)

withMaxiDC.js:56 {code: 'rest_no_route', message: 'No route was found matching the URL and request method.', data: {…}}

Screenshot from 2024-06-27 13-12-25

@elzadj elzadj assigned elzadj and unassigned myroslavve Jun 27, 2024
@elzadj
Copy link
Collaborator

elzadj commented Jun 28, 2024

  • 404 no route error
  • Need to add ACF support for CPT
  • Custom taxonomies support for CPT (like we support categories for posts)
  • Change the UI to be more logical (?)

@elzadj elzadj mentioned this issue Jul 5, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants