Skip to content

Commit

Permalink
fix/ jslib in main process error
Browse files Browse the repository at this point in the history
  • Loading branch information
maximegris committed Aug 22, 2018
1 parent d8818c1 commit ef33f5e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ You can desactivate "Developer Tools" by commenting `win.webContents.openDevTool

**Your application is optimised. Only /dist folder and node dependencies are included in the executable.**

## You want to use a specific lib (like rxjs) in electron main thread ?

You can to this! Just by importing your library in npm dependencies (not devDependencies) with `npm install --save`. It will be loaded by electron during build phase and added to the final package. Then use your librairy by importing it in `main.ts` file. Easy no ?

## Browser mode

Maybe you want to execute the application in the browser with hot reload ? You can do it with `npm run ng:serve:web`.
Expand Down
5 changes: 0 additions & 5 deletions main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ import { app, BrowserWindow, screen } from 'electron';
import * as path from 'path';
import * as url from 'url';

import { of } from 'rxjs';
import { timeout } from 'rxjs/operators';

let win, serve;
const args = process.argv.slice(1);
serve = args.some(val => val === '--serve');
Expand Down Expand Up @@ -45,8 +42,6 @@ function createWindow() {
win = null;
});

of(2000).pipe(timeout(1000))
.subscribe(val => console.log(`ES5 works fine : @${val}`));
}

try {
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-electron",
"version": "4.2.0",
"version": "4.2.1",
"description": "Angular 6 with Electron (Typescript + SASS + Hot Reload)",
"homepage": "https://github.com/maximegris/angular-electron",
"author": {
Expand Down Expand Up @@ -37,7 +37,8 @@
"test": "npm run postinstall:web && ng test",
"e2e": "npm run postinstall:web && ng e2e"
},
"dependencies": {},
"dependencies": {
},
"devDependencies": {
"@angular-devkit/build-angular": "0.6.3",
"@angular/cli": "6.1.2",
Expand Down

1 comment on commit ef33f5e

@kgrandly
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.