Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests for core components #24

Open
maximskripnik opened this issue May 10, 2020 · 1 comment
Open

Refactor tests for core components #24

maximskripnik opened this issue May 10, 2020 · 1 comment
Assignees
@maximskripnik

Comments

@maximskripnik
Copy link
Owner

Current unit tests are prone to race conditions and in fact present only for the sake of coverage. They don't really do actual testing. Instead, a set of proper integrated tests should be introduced
@maximskripnik maximskripnik self-assigned this May 10, 2020
@maximskripnik
Copy link
Owner Author

Removed tests for WorkloadSupervisorActor in this commit: 5e85f0a

This spec was failing ci build way too often, so since those tests will be refactored later anyway, might as well drop them for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximskripnik maximskripnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maximskripnik