Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryPropertyFormat.Int64 is implemented incorrectly. #29

Closed
MaximumADHD opened this issue Oct 14, 2018 · 1 comment
Closed

BinaryPropertyFormat.Int64 is implemented incorrectly. #29

MaximumADHD opened this issue Oct 14, 2018 · 1 comment
Assignees
@MaximumADHD
Labels
bug todo

Comments

@MaximumADHD
Copy link
Owner

MaximumADHD commented Oct 14, 2018 •
edited
Loading

https://github.com/CloneTrooper1019/Rbx2Source/blob/master/src/Reflection/BinaryFormat/Chunks/PROP.cs#L423-L441

The buffer variable should be defined outside the for loop, and it should read instCount*8 bytes.
@MaximumADHD MaximumADHD self-assigned this Oct 14, 2018
@MaximumADHD MaximumADHD changed the title Binary int64 implementation is wrong BinaryPropertyFormat.Int64 is implemented incorrectly. Oct 14, 2018
@MaximumADHD
Copy link
Owner Author

Patched in v2.22

MaximumADHD pushed a commit that referenced this issue May 25, 2023
@qfoxb
Merge pull request #29 from timelessnesses/main
85d667c 
cleanups + convert ids to long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaximumADHD MaximumADHD

Labels
bug todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaximumADHD