Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with latest helm chart 1.8.3 #90

Closed
TLINDEN opened this issue Oct 6, 2023 · 5 comments
Closed

Issues with latest helm chart 1.8.3 #90

TLINDEN opened this issue Oct 6, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@TLINDEN
Copy link

TLINDEN commented Oct 6, 2023

This is a follow-up to #86.

No past versions anymore

As already mentioned in #86 the latest index.yaml only contains the current version, no past ones. This breaks backwards compatibility with existing deployments in production environments where versions are pinned to specific tested versions. You should include past versions again as you did with earlier versions of the chart.

versioning scheme inconsistent with git version tags

The current version of mgob is 1.12.17, there's also a matching git tag. However, if I specify this version in my values.yaml as:

image:
  tag: "1.12.17"

then the helm install fails with this error:

Failed to pull image "docker.io/maxisam/mgob:1.12.17": rpc error: code = NotFound desc = failed to pull and unpack image "docker.io/maxisam/mgob:1.12.17": failed to resolve reference "docker.io/maxisam/mgob:1.12.17": docker.io/maxisam/mgob:1.12.17: not found

It finally worked with 1.12.17-all. But IMHO you should provide an image with only 1.12.17 as well.

Thanks a lot however for the work you put into mgob and the helm chart, this is much appreciated!

best regards,
Tom

@maxisam
Copy link
Owner

maxisam commented Oct 6, 2023

thx for reporting. I think I might just push this to docker oci register. much simpler that way I think.

@maxisam maxisam self-assigned this Oct 6, 2023
@maxisam maxisam added the bug Something isn't working label Oct 6, 2023
@maxisam
Copy link
Owner

maxisam commented Oct 8, 2023

hi, I push it to docker hub now
pls try

helm pull oci://registry-1.docker.io/maxisam/mgob --version 1.8.3

@TLINDEN
Copy link
Author

TLINDEN commented Oct 9, 2023

This works, but I didn't talk about the helm chart version in this issue, but the actual image version. If one specifies an image version in value.yaml then it needs to be 1.12.17-something at the moment - which is ok and works but is not consistent with git tags, since there are no 1.12.17-something at the moment, only 1.12.17 :)

What I reported in the other issue though was, that the repo doesn't support installing past versions of the chart. Look:

helm pull oci://registry-1.docker.io/maxisam/mgob --version 1.8.2
Error: registry-1.docker.io/maxisam/mgob:1.8.2: not found

(same with github.io). That's because the index.yaml only contains the latest version.

Does that make sense?

@maxisam
Copy link
Owner

maxisam commented Oct 10, 2023

Sorry I thought you were talking about the same issue from the previous thread.
for "No past versions anymore", that is because I didn't publish those past version to dockerhub. But from now on, this won't be a problem anymore 🤞 Dockerhub should keep every version in the future.

For "versioning scheme inconsistent with git version tags", I think I will just add a tag "1.12.17" to 1.12.17-all. Do you think that will work?

@TLINDEN
Copy link
Author

TLINDEN commented Oct 10, 2023

But from now on, this won't be a problem anymore 🤞 Dockerhub should keep every version in the future.

Great!

For "versioning scheme inconsistent with git version tags", I think I will just add a tag "1.12.17" to 1.12.17-all. Do you think that will work?

Very nice :)

Thanks a lot!

Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants