Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we use Their own compose to listDialog item view? #5

Closed
nideshouhei opened this issue Nov 3, 2022 · 8 comments
Closed

can we use Their own compose to listDialog item view? #5

nideshouhei opened this issue Nov 3, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@nideshouhei
Copy link

No description provided.

@maxkeppeler
Copy link
Owner

I do not see much sense in doing so. If you want to have a list with custom item views, you could just use CoreDialog / InfoDialog and display your own list-item views in the content section. On the other hand, it wouldn't be difficult to allow that. Can you tell me a bit more about your use-case?

@nideshouhei
Copy link
Author

i just want to get pic from url by coil in list item left

@maxkeppeler
Copy link
Owner

Oh, hm, let me think about it. Basically an optional composable function that would replace the icon. I will reopen the ticket. The images wouldn't be very large, though - is that intended?

@maxkeppeler maxkeppeler reopened this Dec 6, 2022
@nideshouhei
Copy link
Author

Most people like individuality .My product manager feels the same way.

@maxkeppeler
Copy link
Owner

I understand and feel the same, especially more configuration options for developers. But I still want to understand your use case. You want to have load dynamic images with coil. The current icon has a size of 24dp. What's the intended size for the image?

@nideshouhei
Copy link
Author

24dp totally enough

@maxkeppeler maxkeppeler added the enhancement New feature or request label Dec 6, 2022
@maxkeppeler
Copy link
Owner

I will plan that for a later version beginning January 2023 as I'm soon in holidays.

@maxkeppeler
Copy link
Owner

I decided against doing this as I do not think it's a common use case. I recommend you to fork the project and add this functionality. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants