New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InfoSheet Enhancements #15
Comments
With text at the bottom, you mean the title below the cover image / Lottie animation? |
yep, having it below the cover image/Lottie animation would work well. I just saw the updates in 1.1.2. The title placement you have already looks great so far, not sure if you already added the Lottie option yet. For the icons on the image area for the Overlapping Cover Image, I would have a contrast background. I'm guessing you're setting android:src to the icon drawable, there's also android:background which should be a white circle if the icon is black. That way it's easier to see the black icons on a black or dark image. |
Great to hear. Did you notice the 3 styles for the top view? I did not work on Lottie animations yet. If you checked out the latest work for the next release, did you play around with the |
You are correct with the note on the missing contrast. It's possible to specify the colors for the icon buttons, so if it's known that the image is bright, dark colors can be used for the icons for a better contrast. That's correct, I'm setting the src for the icon drawable. However, I'm using the background for a ripple drawable. |
Yep, I love the stuff I have seen so far. The top views should be more than enough for all the use cases. The SheetStyle is great for options, but you might have to change the name of the project though. :) The icon background color would be a great addition. Looking forward to the next release! |
I will, probably to just "Sheets". Ehm. Not sure when though, I would want to change the dependency names and general structure of the modules then too. |
Describe the solution you'd like
Request to add more features to the InfoSheet:
*Url sources cover dynamic pictures, and the drawable covers icons + other static pictures
The text was updated successfully, but these errors were encountered: