Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking MKRingProgressView to objective-c project #31

Closed
StefanBouwer opened this issue Feb 27, 2018 · 7 comments
Closed

Linking MKRingProgressView to objective-c project #31

StefanBouwer opened this issue Feb 27, 2018 · 7 comments

Comments

@StefanBouwer
Copy link

I have a framework that I have built myself, with its own podspec and one of its dependencies is MKRingProgressView. Note that my framework and the rest of its dependencies are written in objective-c.

pod lib lint does validate successfully with my framework's podspec, although whenever I do a pod install on another project with my framework, I get this error on the MKRingProgressView framework whenever I try to compile:

The "Swift Language Version" (SWIFT_VERSION) build setting must be set to a supported value for targets which use Swift. This setting can be set in the build settings editor.

Isn't it necessary that MKRingProgressView needs to specify the swift version in its podspec as well?

Also, it looks like a few of open var are not translated as properties when MKRingProgressView-Swift.h is imported out of an objective-c project. Adding the @objc attribute to these variables may fix it.

@maxkonovalov
Copy link
Owner

Hello @StefanBouwer,

There's no such setting as swift version in podspec. However, the lib has a .swift-version file as required. My guess is that the above error comes from somewhere else. I'd suggest you to try adding a .swift-version file to your framework that depends on swift framework, and also try adding MKRingProgressView pod directly to your main project to make sure it works there.

As for missing @objc attributes, I'll update the lib to make it compatible with objective-c, too ✌🏻

@StefanBouwer
Copy link
Author

So we managed to add the MKRingProgressView pod as a dependency. And it works great now. Like you mentioned, the @objc attribute is still the only thing missing :).

Thanks a ton @maxkonovalov.

@maxkonovalov
Copy link
Owner

@StefanBouwer great! I'll let you know once I release an update.

@StefanBouwer
Copy link
Author

Thanks man 👌.

@maxkonovalov
Copy link
Owner

@StefanBouwer, objc support is here 🎉
Please let me know if you have any issues.

@StefanBouwer
Copy link
Author

@maxkonovalov Thanks a ton! This library is awesome btw 😝!

@maxkonovalov
Copy link
Owner

Thank you! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants