-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot login with my regular account #21
Comments
no, your normal Wikidata username and password should do normally |
Well, I have my Wikimedia account set up for 2FA, not sure if that interferes here. |
@waldyrious possibly. Also to have in mind: the current implementation relies on a deprecated query https://github.com/maxlath/wikidata-token/issues/5 |
@waldyrious hey, will you be in Vienna for the Wikimedia Hackathon next week? we could take the occasion to tackle this issue :) |
Unfortunately not :( but we could set up a time to chat over IRC during the hackathon :) |
sure! I should be able to find knowledgeable people in the room to give us a clue or two ;) |
Great! Let me know when you know what your availability will be during those days. During the workweek, I am generally available at night (around 8pm-11pm UTC). |
so it seems we can take inspiration on @addshore's login code that does support 2FA: MWApi.java |
OAuth authentification is now possible (and recommanded!) in |
Great to hear that, @maxlath. However I think the UX needs a little polish:
A clear message and call should be shown, e.g. "You don't seem to have an OAuth token set yet; please open the following URL to create one". Especially since when I open that URL I see this huge and complex form: ...when I expected an authorization screen like those that appear when I authorize a Labs tool on mediawiki.org (i.e. a dialog where I can just click "Authorize"). So although this may work (I didn't continue further), is it OK if I keep this issue open until that flow is smoothed out a bit? |
could you open a new issue on this? |
Sure. Something like "Improve authentication flow"? |
"Improve OAuth authentication flow"? |
Sounds good, will do 👍 |
Do I have to use a bot account? The error suggests otherwise, but I'm not sure how to proceed:
(Since this seemed to be a loop, at this point I exited with Ctrl+C).
The text was updated successfully, but these errors were encountered: