Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity/Item naming issue #15

Closed
maxlath opened this issue Mar 19, 2017 · 0 comments
Closed

Entity/Item naming issue #15

maxlath opened this issue Mar 19, 2017 · 0 comments

Comments

@maxlath
Copy link
Owner

maxlath commented Mar 19, 2017

In helpers such as isWikidataEntityId the term entity is wrongly used to designate items: in Wikidata lexic, entities include both properties and items.
Also, we could drop the wikidata part in most helpers names given it's a lib about Wikidata.
Both changes would constitute breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant