Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

inconsistancy in quotes #36

Closed
Zen4All opened this issue Feb 2, 2016 · 2 comments
Closed

inconsistancy in quotes #36

Zen4All opened this issue Feb 2, 2016 · 2 comments

Comments

@Zen4All
Copy link

Zen4All commented Feb 2, 2016

why are in https://github.com/maxmind/geoip-api-php/src/geoipregionvars.php some numbers in the array surrounded by quotes, and some are not?
In thought they all needed to be in quotes
for example
'AF' => array ( '01' => 'Badakhshan', '02' => 'Badghis', '03' => 'Baghlan', '05' => 'Bamian', '06' => 'Farah', '07' => 'Faryab', '08' => 'Ghazni', '09' => 'Ghowr', 10 => 'Helmand', 11 => 'Herat', 13 => 'Kabol', 14 => 'Kapisa', 17 => 'Lowgar', 18 => 'Nangarhar', 19 => 'Nimruz', 23 => 'Kandahar', 24 => 'Kondoz', 26 => 'Takhar', 27 => 'Vardak', 28 => 'Zabol', 29 => 'Paktika', 30 => 'Balkh', 31 => 'Jowzjan', 32 => 'Samangan', 33 => 'Sar-e Pol', 34 => 'Konar', 35 => 'Laghman', 36 => 'Paktia', 37 => 'Khowst', 38 => 'Nurestan', 39 => 'Oruzgan', 40 => 'Parvan', 41 => 'Daykondi', 42 => 'Panjshir', ),

@oschwald
Copy link
Member

oschwald commented Feb 2, 2016

Are you trying to solve a particular problem? That file is automatically generated. The ones with quotes have a leading 0 that needs to be quoted to be interpreted correctly.

@oschwald oschwald closed this as completed Feb 2, 2016
@Zen4All
Copy link
Author

Zen4All commented Feb 2, 2016

No particular problem just an observation ;) . I was doing a comparison with an older version of the file, and they had all double quotes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants