Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer tests are dumped on end-users #55

Closed
assistcontrol opened this issue Nov 7, 2019 · 2 comments
Closed

Developer tests are dumped on end-users #55

assistcontrol opened this issue Nov 7, 2019 · 2 comments

Comments

@assistcontrol
Copy link
Contributor

The Makefile includes:

  go fmt ./...
  golangci-lint run
  go test ./...

Those are for you, the upstream developers, and belong in a test target. It's not useful for end-users to reformat or lint the source files, nor to expect that they have golangci-lint installed.
@horgh
Copy link
Contributor

horgh commented Nov 7, 2019

Good point, thanks for mentioning it!

@horgh horgh closed this as completed in 77f3d71 Nov 7, 2019
@assistcontrol
Copy link
Contributor Author

Wow, that was fast. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@horgh @assistcontrol