New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swap out fs-extra.copy for tar-fs #151
Comments
There's also cpy. |
I wrote this for something else just now, its 12 lines: https://github.com/maxogden/cptar |
ncp sometimes has issues (see #150 and #151) -- use cptar instead
Wondering if this would fix an issue I'm having... When I run packager I get errors across a few apps. Chrome quits itself most fo the time and won't re-open without crashing until after packager runs. And then VSCode complains of too many open file references. Guessing this is due to large amounts of node_modules. Currently am able to build most of the app into webpack bundles which may be the way to go. Just realized this is a couple years old... |
@natew Probably not. |
I've been testing this enhancement off and on over the past week. The amount of code that has to change isn't bad, however there is a consistent performance decrease that I've noticed. It adds about a minute to the testsuite when I run it locally. |
For reference: any replacement of |
I'm closing this due to the performance drop I saw. |
to fix #150
we should switch to using https://www.npmjs.com/package/tar-fs:
tarfs.pack().pipe(tarfs.extract())
, its likeJSON.parse(JSON.stringify(obj))
but for filesystems :) it's a simpler solution than using ncp, which is not currently maintainedpatch welcome!
The text was updated successfully, but these errors were encountered: